3P crashes when dragging Notepad++ tab to separate instance

UffLin commented 6 years ago

Description of the Issue

3P error message when dragging a file tab from one instance of Notepad++ "out of Notepad++" to be shown in separate instance of Notepad++

Steps to Reproduce the Issue

Open a text file in Notepad++. Open another text file in same instance. Now, you have two tabs with each file.
Press and hold mouse button on second tab and drag it outside Notepad++

Expected Behavior

Second file to be shown in separate instance of Notepad++ without error message. Error not shown when 3P not installed.

Actual Behavior

Second file is shown in separate instance but 3P error message is shown: "An error occurred and we wouldn't display a notification". On another pc I was informed that Notepad++ crashed: "It seems that notepad++ didn't stop correctly" (3P message)

Debug Information

3P v 1.8.2. Notepad++ v7.5.9 (32 bit)

jcaillon commented 6 years ago

Hello,

Can you go to your plugin folder and then upload the following file : plugins\config\3P\Log\error.log in this issue please?

Best regards

jcaillon commented 6 years ago

I can reproduce the second part, e.g. this message:

But this is just an information and does not cause notepad++ to stop.

I'm interested in the case where you have:

"An error occurred and we wouldn't display a notification"

UffLin commented 6 years ago

Hi Julien,

It is correct that Notepad++ continues to run even though the "Notepad++ crashed" message appears. But it only happens when 3P is installed so it must be related to 3P.

The other message I receive is happening when I run Notepad++ on server Windows Server 2012 R2 Standard: [cid:image001.png@01D47A6C.88DF76F0] I receive it when no Notepad++ instance is running and I just open the error log. I have attached the error log.

It only happens once = first time I drag tab out of first Notepad++ to become a file in separate (second) instance of Notepad++. Subsequent dragging of tab to separate instance does not crash. I have just removed the 3P plugin on server and used the Plugin Manager to install 3P. It appears that .Net 4.6.1 isn't installed.

.Net 4.6.1 installed. Message "An error has occurred …" does not appear anymore. Sorry for alarm. Obviously it was my installation that was incomplete.

The "Notepad++ crashed" continues to appear.

Med venlig hilsen/Best regards

Uffe Lindhard

System Manager

Group IT

M +45 40282494

Kompan A/S

C F Tietgens Boulevard 32c

5220 Odense SØ

Denmark

[cid:image002.png@01D47A78.9DE2AED0]

Let’s play at Kompan.comhttp://www.kompan.com/ | LinkedInhttps://www.linkedin.com/company/32875/

From: Julien Caillon notifications@github.com Sent: 11. november 2018 11:49 To: jcaillon/3P 3P@noreply.github.com Cc: Uffe Lindhard UffLin@Kompan.com; Author author@noreply.github.com Subject: Re: [jcaillon/3P] 3P crashes when dragging Notepad++ tab to separate instance (#239)

I can reproduce the second part, e.g. this message:

[image]https://user-images.githubusercontent.com/11553075/48311950-aaa46600-e5a7-11e8-9525-baed13d9d2c4.png

But this is just an information and does not cause notepad++ to stop.

I'm interested in the case where you have:

"An error occurred and we wouldn't display a notification"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jcaillon/3P/issues/239#issuecomment-437659767, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AqyX8SE1RrXIKTHP7moN0LawFMBecwD6ks5uuACngaJpZM4YUdBy.

jcaillon commented 6 years ago

Ok nice. If i summarize:

you get the notepad++ has crashed popup when you drag a tab out of notepad++ (thus creating a new instance of notepad) -> Ok, i will correct that
the other issue you encountered where 3P was unable to display the notification is caused by .net framework 4.6.1 not installed -> Ok as well, can't do much on this one!

Thanks for the feedback.

Best regards

jcaillon / 3P