jcaiuwyo / cantera

Automatically exported from code.google.com/p/cantera
0 stars 0 forks source link

ck2cti.py adds duplicate species to the species list #199

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add duplicate species to the SPEC section of the CHEMKIN input file
2. Run ck2cti with the --permissive option
3. Import the resulting cti

What is the expected output? What do you see instead?
Cantera throws an error because a species is declared multiple times.

What version of the product are you using? On what operating system?
2.2a1 on Ubuntu 12.04

Please provide any additional information below.
See the forum thread: 
https://groups.google.com/forum/#!topic/cantera-users/aUpXHB34IjM

Attached please find a patch to fix this problem based on r2644. 

The attached patch also fixes a potential problem where the SPEC section is 
ended by either the THERMO or REAC keywords (instead of END). ck2cti supports 
this case (grudgingly). If the SPEC section is ended by THERMO ALL or REAC 
CAL/MOL (or any UNITS), the ALL or UNITS will be popped and ck2cti tries to 
find THERMO or REAC in the thermo data, which fails. This is kind of a corner 
case, but if ck2cti supports non-standard section endings, I think it should 
support the corner cases as well.

Bryan

Original issue reported on code.google.com by bryan.w....@gmail.com on 5 Jan 2014 at 6:33

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2660.

Original comment by yarmond on 6 Jan 2014 at 6:46

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2695.

Original comment by yarmond on 23 Jan 2014 at 3:06

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2902.

Original comment by steven.d...@gmail.com on 25 Apr 2014 at 11:49