search

jcaiuwyo / cantera

Automatically exported from code.google.com/p/cantera
0 stars 0 forks source link

Invalid memory access in MaskellSolidSolnPhase_Test.construct_from_xml #209

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The MaskellSolidSolnPhase_Test.construct_from_xml test results in invalid 
memory access in the function installShomateThermoFromXML, apparently because 
the polynomials provided in the test input file are incomplete. See the 
attached Valgrind output for details. Note that the error occurs both with the 
"bad" input file as well as the "good" input file.

While this exact error could be fixed by adding the missing terms to the input 
file, a better fix would be to also check that the array read in 
installShomateThermoFromXML is of the expected size and throw an exception if 
it is not.

Original issue reported on code.google.com by yarmond on 5 Mar 2014 at 3:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in r2778

Original comment by victorbr...@gmail.com on 6 Mar 2014 at 12:10