Closed GoogleCodeExporter closed 9 years ago
This behavior was changed in r1350. You should be aware that before that point,
third-body efficiencies for undefined species resulted in writing to
out-of-bounds memory, resulting in unknown behavior.
Your use case seems reasonable, so I think the change to make will be to have
an option "skip_undeclared_third_bodies" that can be set on a phase definition
to allow the behavior you specified, leaving the current behavior as default
(which helps catch typos in the input files).
Original comment by yarmond
on 26 Apr 2012 at 8:44
Thank you very much, that would be very helpful.
And thanks for alerting me to the silent bug in my present usage!
Original comment by benjamin...@gmail.com
on 26 Apr 2012 at 8:53
This feature has been added in r1472.
Original comment by yarmond
on 18 May 2012 at 10:45
Thanks!
Could you please clarify the syntax for specifying the requisite option
"skip_undeclared_species" in the XML file? Not sure where it goes...
Original comment by benjamin...@gmail.com
on 30 Jul 2012 at 5:58
In the XML format, the way to add this option is as a child of the
"reactionArray" element of the "phase" element. If you have:
<reactionArray datasrc="#reaction_data" />
this should be replaced with:
<reactionArray datasrc="#reaction_data">
<skip third_bodies="undeclared" />
</reactionArray>
Original comment by yarmond
on 30 Jul 2012 at 7:48
Original issue reported on code.google.com by
benjamin...@gmail.com
on 23 Apr 2012 at 2:13Attachments: