Cocoapods 1.4.0+ is broken

NiltiakSivad commented 6 years ago

Hello,

I've been using your handy little tool with Cocoapods 1.3.1, but after trying to upgrade to Cocoapods 1.5.2, I get an error. I also verified that it is broken for Cocoapods 1.4.0. Both result in the following error:

Command

/usr/local/bin/pod deploy

Stack

   CocoaPods : 1.5.2
        Ruby : ruby 2.3.3p222 (2016-11-21 revision 56859) [universal.x86_64-darwin17]
    RubyGems : 2.5.2
        Host : Mac OS X 10.13.4 (17E199)
       Xcode : 9.3.1 (9E501)
         Git : git version 2.15.1 (Apple Git-101)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib
Repositories :

Plugins

cocoapods-deintegrate : 1.0.2
cocoapods-deploy      : 0.0.12
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.0
cocoapods-try         : 1.1.0

Podfile

platform :ios, '10.0'

target 'TestProject' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for TestProject

  pod 'RxSwift', '4.1.2'
  pod 'Moya/RxSwift', '11.0.2'
  pod 'Nuke', '6.1.1'

  target 'TestProjectTests' do
    inherit! :search_paths
    # Pods for testing
  end

  target 'TestProjectUITests' do
    inherit! :search_paths
    # Pods for testing
  end
end

Error

ArgumentError - wrong number of arguments (given 1, expected 0)
/Library/Ruby/Gems/2.3.0/gems/cocoapods-deploy-0.0.12/lib/cocoapods-deploy/deploy_installer.rb:3:in `create_analyzer'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.2/lib/cocoapods/installer.rb:147:in `resolve_dependencies'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.2/lib/cocoapods/installer.rb:116:in `install!'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-deploy-0.0.12/lib/cocoapods-deploy/command/deploy.rb:131:in `install'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-deploy-0.0.12/lib/cocoapods-deploy/command/deploy.rb:142:in `run'
/Library/Ruby/Gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.2/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.2/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:22:in `load'
/usr/local/bin/pod:22:in `<main>'

jcampbell05 commented 6 years ago

Thanks for the bug report :) Looks like some of the internals we are using for the tool have changed in Cocoapods. Hopefully not a big change but I'll investigate :)

NiltiakSivad commented 6 years ago

@jcampbell05 Probably not an easy fix?

jcampbell05 commented 6 years ago

@NiltiakSivad it looks like they have tidied up some of the class names. potentially easy but I haven't found the time to look into this yet

ManWithBear commented 5 years ago

Any progress so far?

jcampbell05 commented 5 years ago

@ManWithBear I haven't had the time to look at this. Happy for someone to take over this.

igor-makarov commented 5 years ago

CocoaPods have added this functionality built-in since verison 1.6.0. Perhaps it's better to use that?

Lutzifer commented 5 years ago

@igor-makarov How do I do it in cocoa pods then? --deployment is a different kind of thing, isn't it?

jcampbell05 commented 5 years ago

There is a slight difference, the new flag cocoapods just lets you know if something has changed. This framework works more like bundle where it finds the direct url for the pod and installs it rather than cloning an entire repo.

I have an issue open to integrate this into cocoapods itself but I didn't find the time to make it happen. Maybe if I have some spare time I may just integrate this into cocoapods and open a PR for them.

Lutzifer commented 5 years ago

@jcampbell05 thanks for the plugin. I tried some hacking on the code yesterday to get the plugin to run (which succeeded) but the resulting workspace/project had some issues. Would be a great addition to cocoapods imho.

jcampbell05 commented 4 years ago

I've tried suggesting they implement this functionality but they haven't been keen in the past. I think they are working to speed things up though

igor-makarov commented 4 years ago

I made another plugin that speeds up pod installation from GitHub:

https://github.com/igor-makarov/cocoapods-git-tarball

I'm thinking, together with CDN specs and --deployment this plugin covers all the cases, no? Also, you could add the CP cache directory to the CI caching step and it'll be very performant!

jcampbell05 commented 4 years ago

I'll have a look but potentially this would solve the issues. Does your plugin allow you to use the faster method only when installing and not when updating ? IS that what you mean't by --deployment ?

WhiteGoldPanda commented 8 months ago

Spam …

Best regards Bogdan Klymenko

On Mon, 19 Feb 2024 at 07:43, PuchkovaAnastasia @.***> wrote:

Hello,

We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!

As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage

Retirement savings plan

Flexible work schedule

Generous vacation and paid time off

Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.

Please click here http://jobs.githubtalentcommunity.online/auth to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.

Important: You have 24 hours to complete the application process.

If you have any questions or need further information, please don't hesitate to contact us.

Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.

Best regards, GitHub Recruitment Team kevinqmcdonald, @leijie2015 https://github.com/leijie2015, @elranu https://github.com/elranu, @HappyKourosh https://github.com/HappyKourosh, @tanyacui https://github.com/tanyacui, @Enigmatic331 https://github.com/Enigmatic331, @libertyAlone https://github.com/libertyAlone, @cdpzyafk https://github.com/cdpzyafk, @JamesonBR https://github.com/JamesonBR, @EhsanRahbari https://github.com/EhsanRahbari, @cartosquare https://github.com/cartosquare, @rymalia https://github.com/rymalia, @lofxf https://github.com/lofxf, @pcoffey https://github.com/pcoffey, @DonorToken https://github.com/DonorToken, @chanharryhk https://github.com/chanharryhk, @UltimoTG https://github.com/UltimoTG, @KiNGxMiDAS https://github.com/KiNGxMiDAS, @PrashantBtkl https://github.com/PrashantBtkl, @l0z0l https://github.com/l0z0l

— Reply to this email directly, view it on GitHub https://github.com/jcampbell05/cocoapods-deploy/issues/11#issuecomment-1951800512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFE3JR43L2ZGAROQQEOJSDYULYAJAVCNFSM4E76FPWKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGE4DAMBVGEZA . You are receiving this because you were mentioned.Message ID: @.***>

jcampbell05 / cocoapods-deploy