jcampbell1 / simple-file-manager

A Simple PHP file manager. The code is a single php file.
MIT License
917 stars 501 forks source link

Symlinks #37

Closed theip4nda closed 7 years ago

theip4nda commented 7 years ago

Can u add a function for following Symlinks?

I added my Usb drive with a symlink to my www dir and i cant open the directory.

Dear Nico

jcampbell1 commented 7 years ago

That may be an issue with your web server setup. I don't think the code has any special handling for symlinks.

On Mon, Feb 13, 2017 at 09:36 theip4nda notifications@github.com wrote:

Can u add a funkction for following Symlinks?

I added my Usb drive with a symlink to my www dir and i cant open the directory.

Dear Nico

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jcampbell1/simple-file-manager/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AABjGz5PL5ts8yWAyx9dprbKTKcG3w30ks5rb8GigaJpZM4L-vIK .

-- Sent from my Commodore 64

theip4nda commented 7 years ago

When i browse the directory withour your php script then i can see and enter my symlink in my www folder. I give my usb drive 777 Rights

jcampbell1 commented 7 years ago

Are you sure it isn't an Apache issue? Have you tried this?

http://superuser.com/questions/244245/how-do-i-get-apache-to-follow-symlinks

Or Nginx:

http://unix.stackexchange.com/questions/157022/make-nginx-follow-symlinks

In all honestly, I am not working on this project. If this is something you need, it is probably most expedient to find something else.

On Mon, Feb 13, 2017 at 12:24 PM, theip4nda notifications@github.com wrote:

When i browse the directory withour your php script then i can see and enter my symlink in my www folder. I give my usb drive 777 Rights

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jcampbell1/simple-file-manager/issues/37#issuecomment-279291774, or mute the thread https://github.com/notifications/unsubscribe-auth/AABjG1nuAweaS-ZEMV4tee5ZCpN9KQLoks5rb9rzgaJpZM4L-vIK .

XanderStrike commented 7 years ago

I can reproduce the issue. Given a directory structure that looks like this:

sfb/
├── Downloads -> /home/xander/Downloads/
└── index.php

Browsing to /sfb/#Downloads gets you an empty directory listing, but /sfb/Downloads/ gets you the Apache file browser guy. Permissions are correct (or else Apache wouldn't serve the directory listing or permit downloading files), so it must be something with the script. I may take some time to look into it but no promises. Just confirming it is the script.

jcampbell1 commented 7 years ago

Should be fixed now.

XanderStrike commented 7 years ago

Can confirm it's definitely fixed, thanks!