jcansdale / gpr

A .NET Core tool for working with the GitHub Package Registry
93 stars 13 forks source link

Error is not written to error output #109

Open jinek opened 3 years ago

jinek commented 3 years ago

If exception happened while executing gpr it is caught by the catch which just returns code 1 https://github.com/jcansdale/gpr/blob/274aa3bb6dcd665e655e03a32d845ecbe31fb647/src/GprTool/Program.cs#L58 My question is why this catch is needed at all, because runtime aready returns non-zero code by itself, additionally the default handler will write error to error stream and other things, like suggestion to attach the debugger. Can't we just simply remove it? Does it give any benefits?