search

jcansdale / gpr

A .NET Core tool for working with the GitHub Package Registry
94 stars 13 forks source link

Don't split spaces #78

Closed jcansdale closed 4 years ago

jcansdale commented 4 years ago

Now that multiple globs can be passed in as args, we don't need to support separating globs with whitespace.

What this PR does

Fixes #70

jcansdale commented 4 years ago

@peters any chance I could get your review of this one?

How would you feel about being made a collaborator? 😄

peters commented 4 years ago

@peters any chance I could get your review of this one?

How would you feel about being made a collaborator? 😄

Thanks for the show of confidence :) I think it's best if we stay with today's model but still review each others PR's :) I think it's simplest when there is only one person responsible for maintaining a stable master :)

jcansdale commented 4 years ago

@peters,

Thanks for the show of confidence :)

Well, your high quality PRs were appreciated!

I think it's best if we stay with today's model but still review each others PR's :) I think it's simplest when there is only one person responsible for maintaining a stable master :)

Cool, I'll keep on tagging you then. Unfortunately I can't add you as a reviewer when you're not a collaborator. GitHub should fix that!

peters commented 4 years ago

@jcansdale Ahh! I didn't know that. You can add me as a collaborator if that solves the problem 👍

jcansdale commented 4 years ago

@peters I've added some null checks and tests since your last review. How does it look now? 🙂

peters commented 4 years ago

@peters I've added some null checks and tests since your last review. How does it look now? 🙂

LGTM 😁👏