Specifying the version when pushing doesn't work for stripping build metadata

jcansdale / gpr

A .NET Core tool for working with the GitHub Package Registry

93 stars 13 forks source link

Specifying the version when pushing doesn't work for stripping build metadata #92

Closed PathogenDavid closed 3 years ago

PathogenDavid commented 4 years ago

As per our discussion here: https://github.community/t/bug-nuget-support-build-metadata-properly/117606/15

It seems gpr push "*.nupkg" --version 1.0.0 doesn't work if the package's version is 1.0.0+BuildMetadata because the two versions are considered to be equivalent.

jcansdale commented 3 years ago

@PathogenDavid I believe the metadata is now being stipped at the GitHub Packages end, so this shouldn't be an issue.

I'm going to close this issue. Please let me know if I've done this to soon. 😉

PathogenDavid commented 3 years ago

I just re-ran my test from August and indeed everything works as expected. Thanks a lot for the update and for getting this fixed! 💜