search

jcarbaugh / python-roku

Screw remotes. Control your Roku with Python.
https://pypi.python.org/pypi/roku
BSD 3-Clause "New" or "Revised" License
288 stars 94 forks source link

Improve Roku TV power support #37

Closed mjg59 closed 4 years ago

mjg59 commented 5 years ago

Roku TVs can be turned on and off, but it's helpful for consumers of the API to be able to determine whether they're talking to a TV and also to figure out what the current state of the TV is. This patch extracts the device type (Box, Stick or TV) from the device info and exports that, and also provides a new power_state method to allow querying of whether the TV is on or off. It also adds the documented PowerOff command supported on TVs.

berg commented 5 years ago

Hey @jcarbaugh! Sorry to bother you, but any chance you'd consider merging this and cutting a new release? I'd love to be able to control my Roku TV's power with Home Assistant.

iantrich commented 5 years ago

@jcarbaugh would love to get this merged in so we can get this info into Home Assistant and utilized in a new front-end card I've been working on https://github.com/custom-cards/roku-card. Thanks!

Villhellm commented 5 years ago

@jcarbaugh another request here for this merge. This would add much needed functionality for home assistant users

iantrich commented 5 years ago

Hey @jcarbaugh, could we get some kind of indication if you're still maintaining this lib? Thanks.

jcarbaugh commented 5 years ago

@iantrich As much as I'd like to think I'd be able to, I really can't maintain this package. I've tried in the past to add additional maintainers and give PyPI access, but they've fallen off too. Are you interested/available?

iantrich commented 5 years ago

I hear that, man. The nature of open source. I'm just getting into the scene in the last year so hopefully I have a good amount of maintainer motivation in me 😄 I'd be game for taking over.

iantrich commented 5 years ago

Going to start testing this tonight now that my schedule is finally clearing up 👍

iantrich commented 4 years ago

Great additions, thanks @mjg59!