jcardama / csgo-market-sniper

Bot that monitors desirable skins and will automatically buy them
GNU General Public License v3.0
20 stars 3 forks source link

suggestions #10

Open notcreeperdude opened 1 year ago

notcreeperdude commented 1 year ago

re add "press enter after logging in" confused me a little at first but i figured it out (thought it was automatic now since it didnt say) Add auto extension downloader to the changelog add page price check. No point having a price limit of $20 but no page limit for it to check pages where everything is over $20

Cheezy1234 commented 1 year ago

if we are running multiple instances should we use multiple Steam accounts or is one account still good? Also if we are trying to buy low-float skins is it faster to sort by float or to not sort at all because sorting takes double the time of not sorting when refreshing?

Also, great work with the update it looks fantastic. I had tried to edit the code and add proxies and the best I could do was add an extension that allowed each instance/window to have a different IP. I will have to buy one of the recommended proxies to try it out.

jcardama commented 1 year ago

re add "press enter after logging in" confused me a little at first but i figured it out (thought it was automatic now since it didnt say) Add auto extension downloader to the changelog add page price check. No point having a price limit of $20 but no page limit for it to check pages where everything is over $20

jcardama commented 1 year ago

if we are running multiple instances should we use multiple Steam accounts or is one account still good? Also if we are trying to buy low-float skins is it faster to sort by float or to not sort at all because sorting takes double the time of not sorting when refreshing?

Also, great work with the update it looks fantastic. I had tried to edit the code and add proxies and the best I could do was add an extension that allowed each instance/window to have a different IP. I will have to buy one of the recommended proxies to try it out.

I would use different steam accounts with different IPs depending on the instance, just to be extra safe, but I'm sure Valve doesn't care at all.

The faster thing would be sorting by float, it takes 3 secs for it to sort by float, then another couple of seconds to go through the page, what I personally do is sort by float and only query 1 page and continue as I only care for low floats and prices that meet the criteria.

And thank you I'm sure there are some free proxy alternatives out there although with some limitations.👍

notcreeperdude commented 1 year ago

re add "press enter after logging in" confused me a little at first but i figured it out (thought it was automatic now since it didnt say) Add auto extension downloader to the changelog add page price check. No point having a price limit of $20 but no page limit for it to check pages where everything is over $20

  • It should be automatic, it might take a few seconds as the bot needs to wait until it finds the logout button, will check if there's a faster way of doing it.
  • Thanks for pointing out the extension downloader!
  • Not sure what your point is on the last one? Are you suggesting sorting by price or doing an overall price check per page and skip if prices are above the criteria?

For the last bit i mean this:

I am looking for skin with specific pattern and a price limit of $10 Because its specific pattern i have it set to look at all pages instead of limiting it to like 5 pages bot looks at all pages, but doesnt account for the price limit while looking. Wasting time looking at pages where everything is over the price limit. If the bot loaded the page then compared the price list to the price limit. If atleast 1 is under the limit, check the page, else if no prices are under the limit, skip to next item

Cheezy1234 commented 1 year ago

I don't know too much about proxy services so I am looking to get one that is able to rotate the IP automatically so I won't get rate limited, also I don't really know the difference between residential vs datacenter proxies. What would be your suggestion for the best option that is less than $20 a month?

Also another edit: would it be possible (or better) to sort by 100 items per page as it is an option with csgofloat extension.

jcardama commented 1 year ago

re add "press enter after logging in" confused me a little at first but i figured it out (thought it was automatic now since it didnt say) Add auto extension downloader to the changelog add page price check. No point having a price limit of $20 but no page limit for it to check pages where everything is over $20

  • It should be automatic, it might take a few seconds as the bot needs to wait until it finds the logout button, will check if there's a faster way of doing it.
  • Thanks for pointing out the extension downloader!
  • Not sure what your point is on the last one? Are you suggesting sorting by price or doing an overall price check per page and skip if prices are above the criteria?

For the last bit i mean this:

I am looking for skin with specific pattern and a price limit of $10 Because its specific pattern i have it set to look at all pages instead of limiting it to like 5 pages bot looks at all pages, but doesnt account for the price limit while looking. Wasting time looking at pages where everything is over the price limit. If the bot loaded the page then compared the price list to the price limit. If atleast 1 is under the limit, check the page, else if no prices are under the limit, skip to next item

Will think on this. The way it works now is that it goes through every listing and extracts and compare at the same time the name, float, pattern and price, it would not save any time by looking at the list of prices overall then skipping to next page if none match the price criteria. What takes a couple of seconds on each page is waiting for the float to be retrieved by the CSGOFloat Market extension. Could make it so that it doesn't wait for the float/pattern value and checks first for the price of each listing.

jcardama commented 1 year ago

I don't know too much about proxy services so I am looking to get one that is able to rotate the IP automatically so I won't get rate limited, also I don't really know the difference between residential vs datacenter proxies. What would be your suggestion for the best option that is less than $20 a month?

Also another edit: would it be possible (or better) to sort by 100 items per page as it is an option with csgofloat extension.

I would suggest at least on Brightdata using the data center option, that provides you with IP rotation and has by far the lowest cost. Would have to compare between the other services.

And thanks for the suggestion I was playing around with it but couldn't make it work yet, but I'm close!

Cheezy1234 commented 1 year ago

is there a way to add a section to the code that will store username/password for Steam and automatically input them? I know we still need to authenticate but it would be nice to have.

Another thing is that if there are more than one items on a given page that fit the buy requirements the bot seems to count all of them toward the items bought however it will only buy one and then go on to the next item or page. I don't know if that is because I messed with the code or if everyone has this problem.

jcardama commented 1 year ago

is there a way to add a section to the code that will store username/password for Steam and automatically input them? I know we still need to authenticate but it would be nice to have.

Another thing is that if there are more than one items on a given page that fit the buy requirements the bot seems to count all of them toward the items bought however it will only buy one and then go on to the next item or page. I don't know if that is because I messed with the code or if everyone has this problem.

Something I'm looking into is for the session to be stored so you don't need to login each time, so storing username/password won't be needed.

I've seen this behavior before in to which it buys an item and skips to next page on previous versions of the bot, shouldn't be doing this by design on the latest version, but will look into it to make sure it is not doing it.

ustricavelma commented 1 year ago

if proxy is only used to reach steam domains, would it help to bypass csgofloat rate-limit?

jcardama commented 1 year ago

When you use a proxy it masks your real IP for every request, not just steam domains, the thing is that on most instances proxy providers recycle IP's which can make it so that the one IP they assign you is flagged by CSGO Float as rate limited.

ustricavelma commented 1 year ago

@jcardama ye thats what i meant, what if we only used flagged proxy ips to avoid steam rate-limits, and use unmasked(unflagged) ip for csgofloat

jcardama commented 1 year ago

@jcardama ye thats what i meant, what if we only used flagged proxy ips to avoid steam rate-limits, and use unmasked(unflagged) ip for csgofloat

Sadly, don't think that is possible, as I have little to no control over how requests are sent using the proxy configuration as the borwser itself decides on how to handle those. Will look into it though.

Cheezy1234 commented 1 year ago

Im not sure if its just me but the bot seems to get slower at refreshing through the pages the longer that it has been running, i don't know if there is an easy fix for this but i just thought i would throw it out there.

ustricavelma commented 1 year ago

Im not sure if its just me but the bot seems to get slower at refreshing through the pages the longer that it has been running, i don't know if there is an easy fix for this but i just thought i would throw it out there.

+1 on that. I've also noticed that bot get slower as the session goes on

ustricavelma commented 1 year ago

I've also noticed that bot always tries to go to the next page even if pages set to 1. This might add up to a lot of unnecessary requests.