Add notifications - Githubissues

jcartledge / atom-phpcbf

https://atom.io/packages/phpcbf

MIT License

3 stars 6 forks source link

Add notifications #4

Closed studioromeo closed 8 years ago

studioromeo commented 8 years ago

Adds some notification popups for when events happen in the script

Reformat successful

Can't find executable

I've also added another one for the times when phpcbf fails and just returned the output of stderr

jcartledge commented 8 years ago

Thanks! I've added some minor string formatting comments to your commits, then I reconsidered and deleted them.

I think all the top line messages need terminal punctuation. Initially I thought this should be a colon to indicate details follow, but I now think for consistency it should be a period.

So, please add periods (full stop) to the end of each addError/addSuccess message.

studioromeo commented 8 years ago

Hey sorry I will get these changes and the other prs added in a future pr :+1:

jcartledge commented 8 years ago

No problem - I had a few minutes so I just went ahead and did it. Let me know if everything is working for you. It's all in 0.2.0.

Thanks for the PRs!