jcasbin / casbin-spring-boot-starter

Spring Boot 2.x & 3.x Starter for Casbin, see example at: https://github.com/jcasbin/casbin-spring-boot-example
https://mvnrepository.com/artifact/org.casbin/casbin-spring-boot-starter
Apache License 2.0
191 stars 70 forks source link

Replace built-in adapter and watcher with official jdbc-adapter and redis-watcher #63

Closed tangyang9464 closed 2 years ago

tangyang9464 commented 2 years ago

Due to historical reasons, casbin-spring-boot-starter has written its own adapter and watcher, which is not unified with the official one, which increases the difficulty of maintenance and confuses users. So we need to use the official adapter and watcher to replace. see official adapter and watcher: redis-watcher jdbc-adapter Related bug:jcasbin#271

tangyang9464 commented 2 years ago

@seriouszyx

seriouszyx commented 2 years ago

@tangyang9464 Roger that. I will compare the differences between the starter and the official adapter and watcher ASAP.

casbin-bot commented 2 years ago

@tangyang9464 @seriouszyx @elfisworking @fangzhengjin

LiYuanHaooo commented 2 years ago

Hi,

Official JdbcAdapater implement BatchAdapater,but casbin-spring-boot-starter not.

So if I want to batch, do I have to wait until release?

seriouszyx commented 2 years ago

Sorry for the delay. I compared the differences between the starter and the official adapter and recorded the features that need to be added in jdbc-adapter.

In addition, jdbc-adapter needs to improve code quality such as invariants, comments, etc.

I'm working on this, some PR will be opened for this issue.

hsluoyz commented 2 years ago

@seriouszyx sounds good!

hsluoyz commented 2 years ago

@imp2002 plz absorb any valuable parts in PR: https://github.com/jcasbin/casbin-spring-boot-starter/pull/65 and make a new PR to fix this issue