search

jcasbin / jdbc-adapter

JDBC adapter for Casbin
https://github.com/casbin/jcasbin
Apache License 2.0
34 stars 38 forks source link

fix: fix null retry policy and conn when not auto-creating db #55

Closed mpokryva closed 2 years ago

mpokryva commented 2 years ago

When I turned off autocreate, I started getting errors from Failsafe saying that outerPolicy (retryPolicy in this case) cannot be null. Also conn is also only set when autocreating the db, which I don't think is intended behavior.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (8a7969d) into master (7bde0b2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files           3        3           
  Lines          90       90           
  Branches       26       26           
=======================================
  Hits           66       66           
  Misses         13       13           
  Partials       11       11
Impacted Files Coverage Δ
.../main/java/org/casbin/adapter/JDBCBaseAdapter.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hsluoyz commented 2 years ago

@tangyang9464 @seriouszyx plz review

hsluoyz commented 2 years ago

@imp2002

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: