feat: improve policy comma handling

jcasbin / jdbc-adapter

JDBC adapter for Casbin

https://github.com/casbin/jcasbin

Apache License 2.0

34 stars 38 forks source link

feat: improve policy comma handling #74

Closed m-ignatov closed 3 months ago

m-ignatov commented 3 months ago

Fix: https://github.com/casbin/jcasbin/issues/413

casbin-bot commented 3 months ago

@tangyang9464 @imp2002 please review

CLAassistant commented 3 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

hsluoyz commented 3 months ago

@m-ignatov plz fix all errors:

m-ignatov commented 3 months ago

@hsluoyz Moving escapeCasbinRule() & escapeSingleRule() to org.casbin.jcasbin.util.Util will clear the errors in the Codebeat scan I guess, but let me know if this change is okay and will proceed.

hsluoyz commented 3 months ago

@m-ignatov

Run all tests in your localhost beforehand, don't test it here
sign CLA

m-ignatov commented 3 months ago

@hsluoyz

Tested and the build seems to pass
I have agreed already, not sure why it does not update here:

m-ignatov commented 3 months ago

@hsluoyz it seems the master pipeline has failed deploying the 2.8.0 version to Maven. Could you check?