jcasbin / lettuce-redis-watcher

Lettuce-Based Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
1 stars 1 forks source link

fix: Remove the loop condition in the test code to fix CI #3

Closed ShingmoYeung closed 1 year ago

ShingmoYeung commented 1 year ago

Remove the loop condition in the test code.

Fix: https://github.com/jcasbin/lettuce-redis-watcher/issues/2

casbin-bot commented 1 year ago

@tangyang9464 @imp2002 please review

hsluoyz commented 1 year ago

@ShingmoYeung plz fix conflicts

image

ShingmoYeung commented 1 year ago

@ShingmoYeung plz fix conflicts

image

@hsluoyz permission denied?

image image

hsluoyz commented 1 year ago

@ShingmoYeung it's your PR. You of course have rights to modify it. If you cannot do it by web, you can modify your commits in git

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@178bebf). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head a1f16af differs from pull request most recent head 01ea04d. Consider uploading reports for the commit 01ea04d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3 +/- ## ========================================= Coverage ? 82.08% ========================================= Files ? 4 Lines ? 134 Branches ? 11 ========================================= Hits ? 110 Misses ? 17 Partials ? 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ShingmoYeung commented 1 year ago

@ShingmoYeung it's your PR. You of course have rights to modify it. If you cannot do it by web, you can modify your commits in git

@hsluoyz fixed it, code-review please

hsluoyz commented 1 year ago

@ShingmoYeung plz fix:

image

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: