search

jcasbin / redis-watcher

Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
4 stars 11 forks source link

add redis-watcher for Jcasbin #2

Closed tangyang9464 closed 3 years ago

tangyang9464 commented 3 years ago

Fix: https://github.com/jcasbin/redis-watcher/issues/1

hsluoyz commented 3 years ago

@fangzhengjin @shy1st plz review.

fangzhengjin commented 3 years ago
  1. Change the package name to org.casbin
  2. Set the version of the compiled bytecode file to 8
  3. Adjust Main.java as a test case and place it in test

---Original--- From: "Yang @.> Date: Sat, Jun 5, 2021 21:18 PM To: @.>; Cc: "ZhengJin @.>;"Review @.>; Subject: Re: [jcasbin/redis-watcher] add redis-watcher for Jcasbin (#2)

@hsluoyz requested your review on: #2 add redis-watcher for Jcasbin.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

tangyang9464 commented 3 years ago

@fangzhengjin It has been modified

shy1st commented 3 years ago

@tangyang9464 Please add the ci.

hsluoyz commented 3 years ago

@tangyang9464 plz always squash/merge your commits into a single commit

fangzhengjin commented 3 years ago

@tangyang9464 The test cases should be placed in the src/test/java directory, because they should not be compiled into a jar.

tangyang9464 commented 3 years ago

@shy1st @fangzhengjin completed

fangzhengjin commented 3 years ago

@tangyang9464 plz fix ci step [Build with Maven] error

tangyang9464 commented 3 years ago

@fangzhengjin fixed

hsluoyz commented 3 years ago

@tangyang9464 plz always squash/merge your commits into a single commit

tangyang9464 commented 3 years ago

@hsluoyz got it

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: