jcasbin / redis-watcher

Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
4 stars 11 forks source link

feat: add password and timeout configuration for connecting to redis #20

Closed seriouszyx closed 2 years ago

seriouszyx commented 2 years ago

Fix: https://github.com/jcasbin/redis-watcher/issues/11

casbin-bot commented 2 years ago

@tangyang9464 @elfisworking @fangzhengjin please review

codecov[bot] commented 2 years ago

Codecov Report

Merging #20 (d2db686) into master (52ee85d) will increase coverage by 4.89%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   82.60%   87.50%   +4.89%     
==========================================
  Files           3        3              
  Lines          46       48       +2     
  Branches        3        3              
==========================================
+ Hits           38       42       +4     
+ Misses          6        3       -3     
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/main/java/org/casbin/watcher/RedisWatcher.java 90.90% <100.00%> (+0.90%) :arrow_up:
src/main/java/org/casbin/watcher/SubThread.java 86.66% <0.00%> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52ee85d...d2db686. Read the comment docs.

casbin-bot commented 2 years ago

@tangyang9464 @elfisworking @fangzhengjin please review

hsluoyz commented 2 years ago

@rongfengliang plz review

elfisworking commented 2 years ago

@seriouszyx using git rebase to merge two commit into one commit . That's better

seriouszyx commented 2 years ago

changed

hsluoyz commented 2 years ago

@seriouszyx plz fix:

image

hsluoyz commented 2 years ago

@seriouszyx can you also add this to the README as a new example? https://github.com/jcasbin/redis-watcher#simple-example

seriouszyx commented 2 years ago

@hsluoyz done

hsluoyz commented 2 years ago

lgtm

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: