jcasbin / redis-watcher

Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
4 stars 11 forks source link

pr for issue #26

Closed xuyukeviki closed 2 years ago

xuyukeviki commented 2 years ago

According to user needs,newly added a constructor to configure JedisPoolConfig by themselves

close: #23

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

casbin-bot commented 2 years ago

@tangyang9464 @seriouszyx @elfisworking please review

hsluoyz commented 2 years ago

@xuyukeviki plz make any necessary changes inside this same PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (8edeff8) into master (bb71006) will increase coverage by 0.92%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   91.66%   92.59%   +0.92%     
==========================================
  Files           3        3              
  Lines          48       54       +6     
  Branches        3        3              
==========================================
+ Hits           44       50       +6     
  Misses          2        2              
  Partials        2        2              
Impacted Files Coverage Δ
src/main/java/org/casbin/watcher/RedisWatcher.java 92.85% <100.00%> (+1.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb71006...8edeff8. Read the comment docs.

hsluoyz commented 2 years ago

Replaced by: https://github.com/jcasbin/redis-watcher/pull/28