search

jcasbin / redis-watcher

Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
4 stars 12 forks source link

feat: add redis pool config #28

Closed xuyukeviki closed 2 years ago

xuyukeviki commented 2 years ago

According to users needs , add a new function to configure jedis pool configurations by users

Fix: https://github.com/jcasbin/redis-watcher/issues/23

casbin-bot commented 2 years ago

@tangyang9464 @seriouszyx @elfisworking please review

hsluoyz commented 2 years ago

@tangyang9464 plz review

codecov[bot] commented 2 years ago

Codecov Report

Merging #28 (4387f55) into master (bb71006) will decrease coverage by 2.77%. The diff coverage is 100.00%.

:exclamation: Current head 4387f55 differs from pull request most recent head 56f33d1. Consider uploading reports for the commit 56f33d1 to get more accurate results

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   91.66%   88.88%   -2.78%     
==========================================
  Files           3        3              
  Lines          48       54       +6     
  Branches        3        3              
==========================================
+ Hits           44       48       +4     
- Misses          2        3       +1     
- Partials        2        3       +1
Impacted Files Coverage Δ
src/main/java/org/casbin/watcher/RedisWatcher.java 92.85% <100.00%> (+1.94%) :arrow_up:
src/main/java/org/casbin/watcher/Subscriber.java 81.81% <0.00%> (-18.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb71006...56f33d1. Read the comment docs.

hsluoyz commented 2 years ago

@tangyang9464 @seriouszyx plz review

hsluoyz commented 2 years ago

@yicm plz review

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: