search

jcasbin / redis-watcher

Redis watcher for jCasbin
https://github.com/casbin/jcasbin
Apache License 2.0
4 stars 11 forks source link

feat: implement setUpdateCallback(Consumer func) for Watcher interface #8

Closed seriouszyx closed 2 years ago

seriouszyx commented 2 years ago

Fix: https://github.com/jcasbin/redis-watcher/issues/10

casbin-bot commented 2 years ago

@tangyang9464 @shy1st @fangzhengjin please review

tangyang9464 commented 2 years ago

@seriouszyx Maybe you can modify the title? Because it sounds like it implements the WatcherEx interface, but it is not.

seriouszyx commented 2 years ago

@tangyang9464 How about this one?

hsluoyz commented 2 years ago

@rongfengliang plz review

rongfengliang commented 2 years ago

@rongfengliang plz review

this seems to be ok

hsluoyz commented 2 years ago

Waiting for: https://github.com/jcasbin/redis-watcher/pull/12 to work

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: