search

jcasbin / shiro-casbin

Apache Shiro's authorization middleware based on Casbin
https://github.com/casbin/jcasbin
Apache License 2.0
6 stars 4 forks source link

fix: update pom to fix distributionManagement #31

Closed imp2002 closed 2 years ago

imp2002 commented 2 years ago

Fix: https://github.com/jcasbin/shiro-casbin/issues/30

I have try it in my repo, and it's success.

401 error in shiro-casbin, that's because there is no permission, two errors cause 401.

One is that the account of ossrh does not have permission.

And the other is that the id of <distributionManagement> is not set correctly, and I found it's in profile release, the release environment doesn't seem to be used by default. So I try use multiple profiles and putting distributionManagement under the release profile in my repo as same as shiro-casbin, the same error as shiro-casbin appeared (https://github.com/imp2002/maven-release-example/commit/54f9c09fdd63e577a0ef30a7948ce2ba206b2b8b).

And move it out to default environment solve it(https://github.com/imp2002/maven-release-example/commit/f35c9412c67a016a86c6214eed87b5e575bed56e).

casbin-bot commented 2 years ago

@tangyang9464 please review

codecov[bot] commented 2 years ago

Codecov Report

Base: 71.76% // Head: 71.76% // No change to project coverage :thumbsup:

Coverage data is based on head (464056f) compared to base (32036c4). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #31 +/- ## ======================================= Coverage 71.76% 71.76% ======================================= Files 7 7 Lines 85 85 Branches 9 9 ======================================= Hits 61 61 Misses 19 19 Partials 5 5 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jcasbin). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jcasbin)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hsluoyz commented 2 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: