search

jcasimir / locale_setter

A simple library to set request locale based on a hierarchy of factors
MIT License
118 stars 18 forks source link

railtie prescribes class naming convention unnecessarily #12

Closed diggabyte closed 10 years ago

diggabyte commented 10 years ago

I had opened https://github.com/jcasimir/locale_setter/pull/11 for this issue, but closed it after I saw the tests were failing and could not get them running locally.

Steps to reproduce: Implement app controller with any other name (or space) EXCEPT 'ApplicationController'

Outcome: locale_setter-0.4.0/lib/locale_setter/railtie.rb:9:in block in <class:Railtie>: uninitialized constant LocaleSetter::Railtie::ApplicationController (NameError)

Expected: runs smoothly. Calling ActionController::Base would be more appropriate and not break apps that have custom app controller name(spaces)

diggabyte commented 10 years ago

Closing this. i will get the tests working and submit a proper pull request.