search

jcasimir / locale_setter

A simple library to set request locale based on a hierarchy of factors
MIT License
118 stars 18 forks source link

Added config block #8

Closed somebody32 closed 11 years ago

somebody32 commented 11 years ago

Hi,

I've added opportunity to change defaults via config block and added dynamic current_user method, so there is no more need for user to configure LocaleSetter via calls to methods of internal modules.

steveklabnik commented 11 years ago

I like this! thanks for doing it. Just a few comments here and there ;).

somebody32 commented 11 years ago

Fixed all these, waiting for any more :)

somebody32 commented 11 years ago

Whoa, forgot that there is no public_send in 1.8, wil replace it with just plain send

steveklabnik commented 11 years ago

So sorry about so much bikeshedding. I should have caught the second bit of english the first time.

steveklabnik commented 11 years ago

Thank you for this, as well as putting up with my incessant bikeshedding. :heart:

somebody32 commented 11 years ago

No problem. Hope that you will bump version soon, so I can point my app not to the repo head, but to a stable release :)

steveklabnik commented 11 years ago

I'll try to do that.

steveklabnik commented 11 years ago

Just released 0.4.0. <3

somebody32 commented 11 years ago

Many thanks for that!