search

jcassee / angular-hypermedia

Hypermedia REST API client for AngularJS applications
MIT License
38 stars 5 forks source link

Allows overriding $merge method in resource implementation class #28

Closed besuhoff closed 8 years ago

besuhoff commented 8 years ago

I'm not sure if that Resource.prototype.$merge call was on purpose (can you clarify it?), but with that I'm unable to override method $merge in descendant class and make it not merge some fields (which I need in my application)

jcassee commented 8 years ago

This looks good. I will take a closer look and merge shortly.

stevermeister commented 8 years ago

:+1:

jcassee commented 8 years ago

@besuhoff Do you need this released?

stevermeister commented 8 years ago

@jcassee, I'll answer for @besuhoff . We are currently using your library in our project and yes it would be very desirable to release new version to npm.

jcassee commented 8 years ago

Alright, just released 0.7.6.

@besuhoff Heads-up: you forgot (and I missed it too) to run gulp before committing so dist/hypermedia.js (which dependent projects use) was not updated. Fixed in the commit that updated the version.

besuhoff commented 8 years ago

Thank you @jcassee!

besuhoff commented 8 years ago

@jcassee I'll also appreciate a lot if you release a new version of npm package at npmjs.org

jcassee commented 8 years ago

Done now! Thanks for reminding me.

besuhoff commented 8 years ago

@jcassee thanks a lot sir!

besuhoff commented 8 years ago

@jcassee sorry to disturb but npm registry is still at 0.7.5 https://www.npmjs.com/package/angular-hypermedia

jcassee commented 8 years ago

Weird, I ran npm publish again, and it's now updated to 0.7.6. Sorry for the confusion!

besuhoff commented 8 years ago

No problem sir, thanks! I now see it there