search

jcavar / refresher

DEPRECATED: Pull to refresh in Swift
MIT License
873 stars 99 forks source link

Move the labelTitle view into the animator. #17

Closed eventualbuddha closed 9 years ago

eventualbuddha commented 9 years ago

This means that anybody who customizes the animator will have to handle this themselves, but I think that’s appropriate as each implementation of this is likely to involve custom branding.

This also makes PacmanAnimator put its graphic in the center since the label is no longer there.

jcavar commented 9 years ago

Hey, thanks for your effort. I completely agree with this, but there is separate branch in which I try to separate things in right way. Similar thing has already been done there so I would like to keep this branch as is and do this kind of things there and merge when things are ready. https://github.com/jcavar/refresher/tree/subviews If you have time you can take a look and let me know what are your thoughts about this?

eventualbuddha commented 9 years ago

That seems better, from the bit I skimmed. I wonder if it makes sense to rename "animator" to "delegate", since that's essentially what it is now. On Fri, Jun 26, 2015 at 12:24 PM Josip Ćavar notifications@github.com wrote:

Hey, thanks for your effort. I completely agree with this, but there is separate branch in which I try to separate things in right way. Similar thing has already been done there so I would like to keep this branch as is and do this kind of things there and merge when things are ready. https://github.com/jcavar/refresher/tree/subviews If you have time you can take a look and let me know what are your thoughts about this?

— Reply to this email directly or view it on GitHub https://github.com/jcavar/refresher/pull/17#issuecomment-115845702.

jcavar commented 9 years ago

Yes, I think you are right. I will do that!