search

jcaw / theme-magic

🎨 Apply your Emacs theme to the rest of Linux, using magic. Also works on Mac.
GNU General Public License v3.0
139 stars 4 forks source link

Melpa suggestions - round 2 #2

Closed jcaw closed 5 years ago

jcaw commented 5 years ago

Implementing the second round of Melpa suggestions from @purcell - https://github.com/melpa/melpa/pull/6085#issuecomment-485216815

Thanks for this, and sorry for the slow response. Mostly looks great. Quick notes:

  • seq is not available in the Emacs version you're targeting. Add a Package-Requires dependency on it.
  • You might like to use zerop here
  • You've got *enable-auto-update and *disable-auto-update functions -- what you want is a global minor mode: just use define-minor-mode for this. :-)

Hope that helps!