search

jcaw / theme-magic

🎨 Apply your Emacs theme to the rest of Linux, using magic. Also works on Mac.
GNU General Public License v3.0
139 stars 4 forks source link

Some themes don't set ANSI colors #4

Closed jcaw closed 5 years ago

jcaw commented 5 years ago

Problem

Some themes do not set the ANSI colors correctly. They seem to use the defaults, which don't match the theme.

Examples

zenburn sets the ANSI colors. This looks good. Look at the color palettes:

theme-magic-zenburn-example

obsidian does not seem to set the ANSI colors. Look at the intermediate colors, 1 through 6. They appear to be the defaults (ignore the background and the foreground - these are not set from the ANSI colors):

theme-magic-obsidian-example

cherry-blossom has the same problem:

theme-magic-cherry-blossom-example

Solution

The only way to get around this would be to set the colors using a different method to the ANSI colors. This could be an optional fallback, which is only used if theme-magic detects that the ANSI colors are unset.

jcaw commented 5 years ago

Working on this and #3 on branch reimplementing_font_extraction