search

jcazevedo / pawned

Also known as “I can’t believe it’s not an online chess club manager.”
2 stars 0 forks source link

Should the Duel model have a match_num? #26

Closed maharifu closed 12 years ago

maharifu commented 12 years ago

If a duel is part of a tournament, than match_num is already in tournament.matches_per_duel.

If it is not a part of a tournament, then I think we should be able to add matches to a duel, instead of predefining how many matches we will want in that duel.

My opinion is we should keep it as an input in the duel form (if the duel is not a part of a round), but just use it to create the initial matches and not store it in the DB as an attribute of a duel.

Discuss... :p

punnie commented 12 years ago

IMHO, a match number should be requested when creating a duel as a convenience to aid the creation of the necessary matches, but I see no reason to store it in the database.

So basically, I agree.

jcazevedo commented 12 years ago

I also agree.

jcazevedo commented 12 years ago

This is already handled. I'm closing it.