Closed jhgoebbert closed 6 years ago
jcb91
commented
6 years ago Thanks for the report, you're right, it should be set. I think we've set this on other repos, I guess I missed it here. Will try to remember to do this in a patch release in the next few days
jhgoebbert
commented
6 years ago Hi Josh,
great - thanks for the quick fix.
Best, Jens Henrik
Dipl.-Ing. Jens Henrik Goebbert Jülich Supercomputing Centre (JSC) Wilhelm-Johnen-Straße, 52425 Jülich, Germany phone: +49 2461 61-96498 email: j.goebbert@fz-juelich.demailto:jh.goebbert@fz-juelich.de
From: Josh Barnes [notifications@github.com] Sent: Saturday, March 24, 2018 2:33 PM To: jcb91/jupyter_highlight_selected_word Cc: Göbbert, Jens Henrik; Author Subject: Re: [jcb91/jupyter_highlight_selected_word] zip_safe=False (#29)
Thanks for the report, you're right, it should be set. I think we've set this on other repos, I guess I missed it here. Will try to remember to do this in a patch release in the next few days
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jcb91/jupyter_highlight_selected_word/issues/29#issuecomment-375889724, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI1maFvpQq0ClJPEXq8o_B9ElXtdjBKxks5thksfgaJpZM4S5uYc.
Hi,
you might want to add "zip_safe=False" to setup.py to ensure, that the pyhton egg is not installed as a file, but as a directory. (check http://setuptools.readthedocs.io/en/latest/setuptools.html#setting-the-zip-safe-flag).
Currently this gives some trouble with jupyter_contrib_nbextensions: https://github.com/ipython-contrib/jupyter_contrib_nbextensions/issues/1269
Best, Jens Henrik