cl:tree-equal mishandles keyword arguments

jcbeaudoin / MKCL

ManKai Common Lisp

Other

33 stars 8 forks source link

cl:tree-equal mishandles keyword arguments #27

Closed davidmullen closed 6 months ago

davidmullen commented 6 months ago

> (tree-equal 'a 'a)

Debugger called in: #<thread "Initial" active (4318) 0x7f859043e740 7f858d9f3000>.

#<a SIMPLE-ERROR 140211509202688>:
    Both :TEST and :TEST-NOT are specified.

This bug can cause a crash.

jcbeaudoin commented 6 months ago

I guess that getting rid of the dpp utility was much too massive a change to happen really smoothly. Too many loose ends to not miss a few. But I still think it was a very valuable step since it recovered usable source code debugging in gdb.

In any case, thank you very much for the catch. It was indeed a potential crash source.

jcbeaudoin commented 6 months ago

should be fixed now with your PR code but I spotted something in pairlist I'll fix soon.

Please check and close the issue if ok.

jcbeaudoin commented 6 months ago

mk_cl_pairlis was already fixed by a previous commit.

Should we close the issue?

davidmullen commented 6 months ago

Yes, pairlis looks OK.