jcberquist / aws-cfml

Lucee/ColdFusion library for interacting with AWS API's
MIT License
72 stars 53 forks source link

support region endpoints for the s3 buckets created outside of us-east-1 #4

Closed justincarter closed 8 years ago

justincarter commented 8 years ago

As per the endpoints listed for S3 here: http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

jcberquist commented 8 years ago

I guess you know which region I like to use...I appreciate the fix.

If you aren't just fixing the repo out of the goodness of your heart, but have an actual use case for the s3 component, be aware that it doesn't currently always work with object version ids (though it claims to), because those query keys are case sensitive and I have the case wrong. I have it fixed locally - I just need to get that pushed up.

justincarter commented 8 years ago

Thanks for the heads up :) I'm looking into the v4 signatures but just wanted to contribute the region fix incase anyone else was using the S3 support outside of the default region. Nice work!

jcberquist commented 8 years ago

Got it, thanks for taking the time. If you can improve the v4 signature code, I would welcome that as well :smiley: