jcberquist / sublimetext-cfml

CFML (ColdFusion and Lucee) package for Sublime Text
MIT License
115 stars 24 forks source link

Custom tags not correctly indexed in subfolders #139

Closed michaelalandawson closed 3 years ago

michaelalandawson commented 3 years ago

The indexer has a strange behavior depending on how the "custom_tag_folders" setting is configured.

I have custom tags located in "C:\home\www\custom-tags" and "C:\home\www\custom-tags\form" folders.

If I use the following setting, the indexer will not find the custom tag within the "C:\home\www\custom-tags\form" folder.

{
  "custom_tag_folders":
    [
      {
        "path": "C:\\home\\www\\custom-tags",
      },
  ],
}

bug1


If I use the following setting, the indexer will find the custom tag in the "\form" folder, however, they are listed twice in the tag completion.

{
  "custom_tag_folders":
    [
      {
        "path": "C:\\home\\www\\custom-tags",
      },
      {
        "path": "C:\\home\\www\\custom-tags\\form",
      },
  ],
}

bug2

Thanks for taking a look at this.

jcberquist commented 3 years ago

Thanks - I can reproduce this. Would you prefer to have a recursive search for custom tags under a given path (so sub folders are searched) or to only index the given folder, but then have the duplication fixed?

michaelalandawson commented 3 years ago

I think having a recursive search for sub folders under a given path would be closer to how ColdFusion "looks" for custom tags in sub folders.

jcberquist commented 3 years ago

Alright, thanks. This fix and your completions cleanup should be in v0.30.6.

michaelalandawson commented 3 years ago

Thanks! You're the best!