jcberquist / sublimetext-cfml

CFML (ColdFusion and Lucee) package for Sublime Text
MIT License
115 stars 24 forks source link

[ER] Don't suggest private methods on cfcs #43

Closed mjhagen closed 8 years ago

mjhagen commented 8 years ago

Is it possible to differentiate between public and private methods on a cfc? I've (only just now) setup a services directory in the cfc_folders feature and I have a bunch of private methods in them that I like to start with underscores unfortunately that makes them appear at the top. If hiding isn't a good option, putting them below public methods might be better?

image

jcberquist commented 8 years ago

I will do this :). I already capture whether methods are private or public, so it shouldn't be too hard. I had to go and confirm for myself that it wasn't doing it already :grin: I guess I have them all there because they are needed when working in the file itself, or in a cfc that extends another that has private methods.

mjhagen commented 8 years ago

Thx! Awesome feature btw, don't know why I hadn't set it up.

elpete commented 8 years ago

So will private methods still be suggested in the cfc they are defined in or in a cfc that extends that one (maybe only when calling super)?

jcberquist commented 8 years ago

@elpete: That is my plan (I want them suggested where they are callable). I definitely don't want to remove private methods from the component completions altogether.

jcberquist commented 8 years ago

This should be taken care of in v0.15.0

mjhagen commented 8 years ago

Works like a charm, thanks! That was a pretty big commit, was it mostly refactoring?

jcberquist commented 8 years ago

Yeah, sorry about that. It is almost entirely tabs to spaces :) The bulk of the work in that branch was for creating this: https://github.com/jcberquist/sublimetext-cfml/blob/master/src/cfml_view.py

I had decided I was going to use spaces going forwards for indentation, and got tired of converting files one by one as I was working on that, so I just finished off all of them. I will try to be better organized next time 😀

mjhagen commented 8 years ago

haha well, if it's to spaces I'm all for it :)