jcbhmr / hayagriva.js

MIT License
0 stars 0 forks source link

Sweep: add the rest of Library methods #5

Closed sweep-ai[bot] closed 10 months ago

sweep-ai[bot] commented 10 months ago

PR Feedback (click)

Summary

Fixes #2.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

sweep-ai[bot] commented 10 months ago

Sandbox Executions

sweep-ai[bot] commented 10 months ago

Rollback Files For Sweep

sweep-ai[bot] commented 10 months ago

Apply Sweep Rules to your PR?

jcbhmr commented 10 months ago

for iter() i want you to return a js Array or even a js Iterator instead of a flat rust Iterator

sweep-ai[bot] commented 10 months ago

🚀 Wrote Changes

Done.

jcbhmr commented 10 months ago
error[E0308]: mismatched types --> src/library.rs:14:46 14 self.0.nth(n).map( entry Entry { 0: entry }) ^^^^^ expected Entry, found &Entry

help: consider using clone here | 14 | self.0.nth(n).map(|entry| Entry { 0: entry.clone() }) | ++++++++

error[E0599]: no function or associated item named from_serde found for struct wasm_bindgen::JsValue in the current scope --> src/library.rs:35:44 35 self.0.iter().map( entry JsValue::from_serde(&Entry { 0: entry.clone() }).unwrap()).collect::().values() ^^^^^^^^^^
function or associated item not found in JsValue
help: there is an associated function with a similar name: from_str
sweep-ai[bot] commented 10 months ago

🚀 Wrote Changes

Done.