jcbkwm / s3fs

Automatically exported from code.google.com/p/s3fs
GNU General Public License v2.0
0 stars 0 forks source link

found segfault in S3fsMultiCurl::MultiRead(void) #437

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Detailed description of observed behavior:

I found segfault in S3fsMultiCurl::MultiRead(void) in "s3fs-1.74"

As you know readdir_multi_head() function registered 
multi_head_retry_callback() at RetryCallback to use retry callback.

And in "multi_head_retry_callback(2121): Over retry count(3) limit" case, 
multi_head_retry_callback() return NULL.

by following code of in S3fsMultiCurl::MultiRead(void)

// For retry
  if(RetryCallback){
     retrycurl = RetryCallback(s3fscurl);
     cMap_all[retrycurl->hCurl] = retrycurl;
  }

retrycurl is NULL, ...........

So I changed like following code
   // For retry
  if(RetryCallback){
     retrycurl = RetryCallback(s3fscurl);
     if(retrycurl)
         cMap_all[retrycurl->hCurl] = retrycurl;
     else
         return -1;
  }

Please check it for me

Best regards,
- BONG

What steps will reproduce the problem - please be very specific and
detailed. (if the developers cannot reproduce the issue, then it is
unlikely a fix will be found)?

===================================================================
The following information is very important in order to help us to help
you.  Omission of the following details may delay your support request or
receive no attention at all.
===================================================================
Version of s3fs being used (s3fs --version):

Version of fuse being used (pkg-config --modversion fuse):

System information (uname -a):

Distro (cat /etc/issue):

s3fs command line used (if applicable):

/etc/fstab entry (if applicable):

s3fs syslog messages (grep s3fs /var/log/syslog):

Original issue reported on code.google.com by b...@gscdn.com on 28 Jul 2014 at 6:16

GoogleCodeExporter commented 8 years ago
Hi, BONG

Thanks for your reports.

This issue has fixed on Github.(We moved s3fs project to 
Github(https://github.com/s3fs-fuse/s3fs-fuse))
Same issue is already fixed by https://github.com/s3fs-fuse/s3fs-fuse/issues/18.
(https://github.com/s3fs-fuse/s3fs-fuse/commit/d7563309a29ea7f06d7df764c9512d7bc
4237004)

Please use s3fs on Github.
Thank you very much.
Takeshi.

Original comment by ggta...@gmail.com on 10 Aug 2014 at 8:50