search

jcchavezs / cmb2-conditionals

Plugin to relate fields in a CMB2 metabox
GNU General Public License v2.0
85 stars 61 forks source link

Does not work on numeric values. #39

Open dash8x opened 7 years ago

dash8x commented 7 years ago

If the data-conditional-value is numeric then it doesn't recognize the selected value as the same.

pgroot91 commented 4 years ago

Not sure but i could be the same as #77 ...

'Bakfiets' <> 'fiets', 'xl' <> 'l', '11' <> '1', 'B,E' <> 'E'

All give unwanted results since the ID/data-conditional-value doesn't check exact match.

jcchavezs commented 4 years ago

Hi both. Thanks for raising the issue. Unfortunately I am out from wordpress world since long time ago so maybe you can come up with a PR taking a stab on the fix?

José Carlos Chávez

lør. 18. apr. 2020 kl. 23:54 skrev Patrick Groot notifications@github.com:

Not sure but i could be the same as #77 https://github.com/jcchavezs/cmb2-conditionals/issues/77 ...

Bakfiets <> fiets, xl <> l, 11, <> 1

All give unwanted results since the ID doesn't check exact match.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jcchavezs/cmb2-conditionals/issues/39#issuecomment-615957050, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAURHDSWLYPVXHATDYDRNIOTFANCNFSM4DBE2NVA .