jcchavezs / cmb2-conditionals

Plugin to relate fields in a CMB2 metabox
GNU General Public License v2.0
85 stars 61 forks source link

Gutenberg Compatibility #64

Open JoeHana opened 5 years ago

JoeHana commented 5 years ago

Gutenberg is coming soon and it seems like the Conditionals Functionality is not given for Metaboxes where Gutenberg is active. I've tried to modify the JS to init on #editor (in addition to #post) but for some reason that doesn't help. I checked the markup and found that there are of course many differences between a metabox loaded within the classic ui and one loaded within gutenberg, but still couldn't spot the part where this might be an issue. For example the #post id was for a form element but the #editor id gets applied to a basic div - not sure if this is the difference since I couldn't spot anything in the JS.

Do you maybe know what the issue might be?

jcchavezs commented 5 years ago

Hi Joe,

Thanks for opening this issue. At the moment I don’t have available time to maintain this plugin (and I don’t work in Wordpress projects anymore) so I would expect users to come up with fixes for new releases. I know you tried to fixed it and I appreciate it so please if you manage to fix it and can come up with a PR for it. Maybe looking at changes in the original CMB plugin for Gutenberg might help?

José Carlos Chávez

  1. nov. 2018 kl. 17:53 skrev Joe Hana notifications@github.com:

Gutenberg is coming soon and it seems like the Conditionals Functionality is not given for Metaboxes where Gutenberg is active. I've tried to modify the JS to init on #editor (in addition to #post) but for some reason that doesn't help. I checked the markup and found that there are of course many differences between a metabox loaded within the classic ui and one loaded within gutenberg, but still couldn't spot the part where this might be an issue. For example the #post id was for a form element but the #editor id gets applied to a basic div - not sure if this is the difference since I couldn't spot anything in the JS.

Do you maybe know what the issue might be?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.