search

jcchavezs / coraza-http-wasm

http-wasm middleware based on Coraza WAF
Apache License 2.0
10 stars 2 forks source link

Sets configuration #6

Closed jcchavezs closed 1 year ago

jcchavezs commented 1 year ago

Ping @codefromthecrypt

anuraaga commented 1 year ago

Sorry I don't think I can put time to review PRs in this repo. I would personally recommend moving it to either a personal repo or tetratelabs, http-wasm doesn't seem to be in coraza's priorities to be honest.

anuraaga commented 1 year ago

Another suggestion is to focus on a proxy-wasm wrapper implementation for http-wasm. Fragmentation is bad, we've already gone through it with observability. I think for coraza, the best situation for now is to focus on coraza-proxy-wasm - if that module can be magically loaded in http-wasm then no problem. If not, it probably needs to be able the with abi tweaks to support it since interoperability is king in middleware.

jcchavezs commented 1 year ago

Thanks @anuraaga. I am moving this repo to my personal namespace as I opened this but it did not went through any consensus on to support it.

On Wed, 26 Jul 2023, 16:32 Anuraag Agrawal, @.***> wrote:

Another suggestion is to focus on a proxy-wasm wrapper implementation for http-wasm. Fragmentation is bad, we've already gone through it with observability. I think for coraza, the best situation for now is to focus on coraza-proxy-wasm - if that module can be magically loaded in http-wasm then no problem. If not, it probably needs to be able the with abi tweaks to support it since interoperability is king in middleware.

— Reply to this email directly, view it on GitHub https://github.com/corazawaf/coraza-http-wasm/pull/6#issuecomment-1651930891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAWICOITAOMTUJ6DCITXSETBJANCNFSM6AAAAAA2VDK56A . You are receiving this because you authored the thread.Message ID: @.***>