search

jcdesimp / Landlord

Bukkit land claiming plugin.
MIT License
11 stars 21 forks source link

Mavenize. #10

Closed jamierocks closed 9 years ago

jamierocks commented 9 years ago

You may want to play round with the versions of WorldGuard and VaultAPI to fit your needs.

jcdesimp commented 9 years ago

I've actually been meaning to put Landlord under Maven, can I get some more details on what exactly you did here?

jamierocks commented 9 years ago

Ok, to start with I created the pom, this is responsible for telling maven how to build your project, it can also be used to automatically get dependencies, next I moved everything into a maven file-structure where the main Java code is under "src/main/java/" also the main resources can be put under "src/main/resources" directory. You could also make tests for your program by placing test code and resources under "src/test/java" and "src/test/resources".

Besides "mavenizing" landlord I also changed some code where it was now depreciated eg a method that used to take a players name then depreciated for a player object, Presumable vault was getting the player object from the name, so you need not worrie about incompatibilities between versions.

— Sent from Mailbox

On Sun, Dec 14, 2014 at 3:29 AM, Joseph DeSimpliciis notifications@github.com wrote:

I've actually been meaning to put Landlord under Maven, can I get some more details on what exactly you did here?

Reply to this email directly or view it on GitHub: https://github.com/jcdesimp/Landlord/pull/10#issuecomment-66901374

jcdesimp commented 9 years ago

Ok cool, did you do any testing to make sure none of the code changes broke anything? Also, I'm currently working on an update for Spigot 1.8 (currently in the develop branch) so once I finalize that branch and merge it into master for release I'll take more of a look at yours and hopefully merging it in can be done cleanly.

I'll keep this request open until then. Thanks again!

jamierocks commented 9 years ago

Ok, Just remember spigot uses different maven repositorys.

— Sent from Mailbox

On Thu, Dec 18, 2014 at 4:53 AM, Joseph DeSimpliciis notifications@github.com wrote:

ok cool, did you do any testing to make sure none of the code stages broke anything? Also, I'm currently working on an update for Spigot 1.8 (currently in the develop branch) so once I finalize that branch and merge it into master for release I'll take more of a look at yours and hopefully merging it in can be done cleanly.

I'll keep this request open until then. Thanks again!

Reply to this email directly or view it on GitHub: https://github.com/jcdesimp/Landlord/pull/10#issuecomment-67441218

jcdesimp commented 9 years ago

@jamierocks Hey sorry to leave you hanging. I've recently began refactoring quite a bit of Landlord resulting in changes in file structure. I've also moved all main development to be off of the "develop" branch rather than master. The master branch is now reserved for release candidates only.

Due to these circumstances I'm going to have to close this PR, however I appreciate your work and still hope to put Landlord under maven at some point in the future.

If you're still up to it, feel free to work off the development branch in order to "Mavenize" it. However given my uncertainty in how the file structure and such will change going forward, I suggest waiting for issue #13 to be closed before doing so. I'm working towards that which will involve abstracting all current hard-coded messages out, resulting in changes to many of the files.

Once again thank you and I hope to hear from you soon.