search

jceb / vim-orgmode

Text outlining and task management for Vim based on Emacs' Org-Mode
http://www.vim.org/scripts/script.php?script_id=3642
Other
3.1k stars 266 forks source link

Decode subprocess output #287

Open nyoxi opened 6 years ago

nyoxi commented 6 years ago

When export fails the output should be messaged to the user. This however did not work on Python 3 because the result of p.communicate() is a tuple of bytes and join() expects strings. This lead to the error:

TypeError: sequence item 0: expected str instance, bytes found
codecov-io commented 6 years ago

Codecov Report

Merging #287 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          49       49           
  Lines        6794     6794           
=======================================
  Hits         5733     5733           
  Misses       1061     1061
Impacted Files Coverage Δ
ftplugin/orgmode/plugins/Export.py 33.82% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce17a40...6b0cc39. Read the comment docs.