search

jceb / vim-orgmode

Text outlining and task management for Vim based on Emacs' Org-Mode
http://www.vim.org/scripts/script.php?script_id=3642
Other
3.1k stars 266 forks source link

Fix export error messages encoding issues #279 #291

Closed sbihel closed 3 years ago

sbihel commented 6 years ago

A fix for issue #279. The bug is fully fixed compared to PR #283.

codecov-io commented 6 years ago

Codecov Report

Merging #291 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          49       49           
  Lines        6794     6794           
=======================================
  Hits         5733     5733           
  Misses       1061     1061
Impacted Files Coverage Δ
ftplugin/orgmode/plugins/Export.py 33.82% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce17a40...d53989a. Read the comment docs.

sbihel commented 6 years ago

u_decode does nothing for python3

akstrfn commented 6 years ago

I know :)

sbihel commented 6 years ago

I am using python3 so it does not fix the bug 🤔 maybe it is more complex than I thought

akstrfn commented 6 years ago

I just checked this from my computer and not mobile and you are right u_decode is useless here. You solution should work.

sbihel commented 6 years ago

Do I have to do anything more?

akstrfn commented 6 years ago

Nothing special, but I'd rewrite the map using a generator i.e. map(lambda x: x.decode(), p.communicate()) -> (x.decode() for x in p.communicate()). But that is just a preference :smile:

jceb commented 3 years ago

Thanks a lot