jceb / vim-orgmode

Text outlining and task management for Vim based on Emacs' Org-Mode
http://www.vim.org/scripts/script.php?script_id=3642
Other
3.1k stars 266 forks source link

Two improvements #375

Closed wl2776 closed 1 year ago

wl2776 commented 2 years ago

1. Gracefully format None in the view "Time line for the current buffer"

Issue: If items in a file don't have TODO, DONE, etc keywords, that is, have a form <date> title, like tl1 below:

* <2022-02-21 Mon> tl1
* TODO <2022-02-22 Tue> tl3

.. then they appear with None in the view "Time line for the current buffer":

None <2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3

Solution: this commit removes these Nones:

 <2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3

2. Add strike-through markup,

gVim now supports it

jbpoittevin commented 2 years ago

wl2776,

The meaning of this PR does not make sense to me, can you explain to me why this modification is useful ?

wl2776 commented 2 years ago

If items in a file don't have TODO, DONE, etc keywords, that is, have a form <date> title:

* <2022-02-21 Mon> tl1
* TODO <2022-02-22 Tue> tl3

.. then they appear with None in the view "Time line for the current buffer":

None <2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3

This commit removes these Nones:

 <2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3
jbpoittevin commented 1 year ago

For inline strikethrough,

I think vim should natively handle strike-through formatting, taking care of this is out of scope for vim-orgmode.

wl2776 commented 1 year ago

So, what is your decision? Will you merge it?

jbpoittevin commented 1 year ago

For the timeline, the white space separator still remaining between the (now) empty string and the date annoys me.

 <2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3

I think the right way to do it would be to include the whitespace only if it is separating the date from something. Can you take care of it ?

wl2776 commented 1 year ago

I think the right way to do it would be to include the whitespace only if it is separating the date from something. Can you take care of it ?

Done!

Source:

* <2022-02-21 Mon> tl1
* TODO <2022-02-22 Tue> tl3

Timeline:

<2022-02-21 Mon> tl1
TODO <2022-02-22 Tue> tl3