jceddy / DailyArenaDeckAdvisor

A Deck Advisor companion App for Magic Arena.
GNU General Public License v3.0
18 stars 7 forks source link

v1.0.3.3 stops at 'processing collection from log' after Eldraine update #22

Closed ghost closed 4 years ago

ghost commented 4 years ago

I tried uninstalling and reinstalling DADA.

log checkbox is on in MTGA.

I can provide logs if desired.

Mark

jceddy commented 4 years ago

They probably broke something with the update. I won't be able to fix it until tomorrow, but I should have a fix by then.

ghost commented 4 years ago

I figured they changed the log file format or something.

On Thu, Sep 26, 2019, 14:45 jceddy notifications@github.com wrote:

They probably broke something with the update. I won't be able to fix it until tomorrow, but I should have a fix by then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jceddy/DailyArenaDeckAdvisor/issues/22?email_source=notifications&email_token=ADFBSI72Z7WPSU6BP4E4JVDQLT7M3A5CNFSM4I25UH62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WSQTY#issuecomment-535636047, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFBSI4XV22OXOXLRFSXT23QLT7M3ANCNFSM4I25UH6Q .

jceddy commented 4 years ago

At least on issue I found was due to the way I was fetching land color data on the server side. Working on fixing that now.

jceddy commented 4 years ago

Thankfully scryfall has now added "historic" as a format for searching...makes my job a lot easier!

ghost commented 4 years ago

Excellent. Available to test when you give me the word.

On Fri, Sep 27, 2019, 09:39 jceddy notifications@github.com wrote:

Thankfully scryfall has now added "historic" as a format for searching...makes my job a lot easier!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jceddy/DailyArenaDeckAdvisor/issues/22?email_source=notifications&email_token=ADFBSI2OVBJF7ZV7XJ44PG3QLYEHLA5CNFSM4I25UH62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7Y5RIQ#issuecomment-535943330, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFBSI5CP4GLRZPSF6BPTGTQLYEHLANCNFSM4I25UH6Q .

jceddy commented 4 years ago

It should actually work with version 1.0.3.3 now...it was only a server-side change. There was an exception due to the lands info not picking up lands like "Foul Orchard", etc.

ghost commented 4 years ago

Testing momentarily

On Fri, Sep 27, 2019, 09:51 jceddy notifications@github.com wrote:

It should actually work with version 1.0.3.3 now...it was only a server-side change. There was an exception due to the lands info not picking up lands like "Foul Orchard", etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jceddy/DailyArenaDeckAdvisor/issues/22?email_source=notifications&email_token=ADFBSI42MDM2IXSEET736NTQLYFXTA5CNFSM4I25UH62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7Y6YXQ#issuecomment-535948382, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFBSI7VCBOVPBVXY26HJVLQLYFXTANCNFSM4I25UH6Q .

jceddy commented 4 years ago

I am actually pushing 1.0.3.4, so you can test with that, if you like.

jceddy commented 4 years ago

It's pushed now...enjoy the progress bars... :P

ghost commented 4 years ago

works now - the progress bars are COOL

On Fri, Sep 27, 2019 at 10:09 AM jceddy notifications@github.com wrote:

It's pushed now...enjoy the progress bars... :P

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jceddy/DailyArenaDeckAdvisor/issues/22?email_source=notifications&email_token=ADFBSI5T6KT4MGVYIFJ5TU3QLYHZ3A5CNFSM4I25UH62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ZAPEA#issuecomment-535955344, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFBSIYYWWWOMWAZXEPMODLQLYHZ3ANCNFSM4I25UH6Q .

jceddy commented 4 years ago

😎 - Good to hear, closing the issue now. Will have updates about new functionality later today.