search

jcelaya / hdrmerge

HDR exposure merging
http://jcelaya.github.io/hdrmerge/
Other
362 stars 78 forks source link

hdrmerge appears to write wrong tag type for NewSubfileType #105

Closed LebedevRI closed 7 years ago

LebedevRI commented 7 years ago 
0x00fe Exif.SubImage1.NewSubfileType                SLong       1   4  0  Primary image

it should be LONG. Yet the code appears to write it correctly.

The sample is https://raw.pixls.us/getfile.php/883/raw/hdrmerge-bayer-fp32-w-pred-deflate.dng Converted from https://raw.pixls.us/getfile.php/771/raw/5G4A9394.CR2 using 

0x0131 Exif.Image.Software                          Ascii      16  16  HDRMerge v0.5.0  HDRMerge v0.5.0

which i think is 8e652a1b17e989e372682bae6fecc4a72fce8312

heckflosse commented 7 years ago

@LebedevRI Why do you think 8e652a1 is related?

LebedevRI commented 7 years ago

i was speaking about the version that i believe i used when generating the dng

heckflosse commented 7 years ago

@LebedevRI Ok, sorry for confusion

heckflosse commented 7 years ago

It's written here.

LebedevRI commented 7 years ago

Aha! So i guess that should be 0u.

LebedevRI commented 7 years ago

Thank you. Though It's interesting that ${adobe dng validity checker} program did not complain (i did not check)