search

jcelaya / hdrmerge

HDR exposure merging
http://jcelaya.github.io/hdrmerge/
Other
355 stars 78 forks source link

update macOS build steps #179

Closed fanckush closed 5 years ago

Beep6581 commented 5 years ago

@fanckush @heckflosse 's remarks are marked as "resolved", but the errors are still there.

@Benitoite are you happy with the contents?

fanckush commented 5 years ago

@Beep6581 I was not aware of how the code review process works and thought that the changes have been made. It's fixed now

Benitoite commented 5 years ago

@Beep6581 It looks fine... I will have to install brew on my 10.12 machine to test it (my 10.14 mac is strictly sans pkg management). I think we should figure out what catch-all brew command will work and include that, the way some projects have a complete, one-shot apt-get command for linuxers. Edit: it's there already, thanks @fanckush.

Benitoite commented 5 years ago

@fanckush please see the results of my testing on 10.12 Sierra with homebrew https://github.com/fanckush/hdrmerge/pull/1

Benitoite commented 5 years ago

@fanckush once you're happy with the changes (you can make further changes) and merge https://github.com/fanckush/hdrmerge/pull/1 to your patch, it should be ready to merge to master.

fanckush commented 5 years ago

I merged the PR. however I removed the git step; I just installed a VM with fresh Sierra 10.12.6 and Xcode Developer Tools do install git behind the scene 👍

If no one has further modifications, I think this can be merged now