search

jcelaya / hdrmerge

HDR exposure merging
http://jcelaya.github.io/hdrmerge/
Other
371 stars 78 forks source link

Fix wrong format "JPEG" for writing the preview. #193

Closed ff2000 closed 5 years ago

ff2000 commented 5 years ago

"JPEG" was valid in Qt4 (alongside "JPG"): https://doc.qt.io/archives/qt-4.8/qimagewriter.html#supportedImageFormats But got dropped in Qt5: https://doc.qt.io/qt-5/qimagewriter.html#supportedImageFormats

Fixes #192

LigH-de commented 4 years ago

This patch does not fix the issue. I compared the following builds:

The DNG files generated by each version are bit-identical, except for the timestamp of creation in their header metadata.

It took me so long to test because nobody built Windows binaries until today.

Beep6581 commented 4 years ago

Seems it does fix the issue after all @LigH-de ? https://github.com/jcelaya/hdrmerge/issues/192#issuecomment-590671494

LigH-de commented 4 years ago

Yes, the reason for failing still was different.