search

jcelaya / hdrmerge

HDR exposure merging
http://jcelaya.github.io/hdrmerge/
Other
354 stars 78 forks source link

LibRaw 0.21 API change #217

Closed m-p-y closed 1 year ago

m-p-y commented 1 year ago

According to LibRaw's changelog the API/datastruct has changed:

2021-09-14 Alex Tutubalin lexa@lexa.ru

  • API/datastruct Changes:
    • imgdata.params.shot_select moved to imgdata.rawparams.shot_select (because this is decode-time option, not postprocessing option)

This change was now released as version 0.21 of LibRaw on Dec 26th 2022 and will break current HDRmerge master branch:

hdrmerge/src/ImageIO.cpp:42:18: error: ‘struct libraw_output_params_t’ has no member named ‘shot_select’ 42 | d.params.shot_select = shot_select;

I included a version check for LibRaw around the offending code (deems just one occurrence) and tested to compile successfully with LibRaw v0.20 and v0.21 on Arch Linux.

Entropy512 commented 1 year ago

Looks like you beat me to this one. (I just fixed this locally a few days ago but hadn't figured out how to ifdef it yet...)