search

jcelaya / hdrmerge

HDR exposure merging
http://jcelaya.github.io/hdrmerge/
Other
363 stars 78 forks source link

Fail on missing aperture #5

Closed Beep6581 closed 10 years ago

Beep6581 commented 10 years ago

I was stumped why the generated DNG image looks fine for some of my shots, and for others it was noisy with magenta colors where clipping in the darkest image of the bracket series occurred. Running it from a terminal I saw that for these images, exposure was reported as infinite. The problem is that most of my images are shot using a manual lens - partial Exif! ISO is there, exposure time is there, but no aperture. Luckily I can use exiftool to hard-code the aperture value, but still it's a pity that HDRMerge silently fails and generates an unusable image when aperture is missing. Since most of my work is in batch, it would be annoying if it asked me for this info every time. It would be great if it either auto-calculated the exposure step between brackets, or at least let us set "If Exif is missing and can't calculate exposure, assume a 2EV step".

I have uploaded sample PEF files from my Pentax K10D taken with a manual Samyang 8mm lens, and a bash script I use to hard-code the aperture info. Please download them soon, as Filebin files seem to expire after a few days. http://filebin.net/3pczcm3rr3

jcelaya commented 10 years ago

Thanks for the feedback. Actually, the iso/speed/aperture trio is only used to quickly sort the exposures at the begining. I will try to sort them without using this information.

jcelaya commented 10 years ago

With the last commit, images are sorted based on average brightness of the image, so no metadata is needed anymore.

Beep6581 commented 10 years ago

Confirmed fix, thank you!