search

jcelliott / turnpike

Go implementation of a WAMP (Web Application Messaging Protocol) client and router
MIT License
258 stars 88 forks source link

Added the ability to register a connection callback. #26

Closed bcurren closed 10 years ago

bcurren commented 11 years ago

I needed to add custom logic when a new connection is established or torn down. I added a callback mechanism that users of turnpike may use to perform any custom connection logic.

maxekman commented 11 years ago

This, and a lot more, is already implemented for both client and server in the dev branch (although not passing the actual WebSocket conn, which seems unnecessary.) I'm planning to add pub/sub handlers on the server also (to enable CRA authentication in the end.)

jcelliott commented 11 years ago

@bcurren, thanks for the contribution. Did you specifically need the Websocket conn object, or will the current implementation in the dev branch work for you?

bcurren commented 11 years ago

I needed the IP address of the client which is why I needed the connection object. Also, the dev branch only has a call for session open but not session closed. I need both callbacks to so I can perform setup and cleanup per client.

Ben Curren http://github.com/bcurren http://twitter.com/bcurren http://thecurrens.com

On Thu, Oct 10, 2013 at 6:17 AM, Joshua C Elliott notifications@github.comwrote:

@bcurren https://github.com/bcurren, thanks for the contribution. Did you specifically need the Websocket conn object, or will the current implementation in the dev branch work for you?

— Reply to this email directly or view it on GitHubhttps://github.com/jcelliott/turnpike/pull/26#issuecomment-26052484 .

jcelliott commented 10 years ago

I'm not sure why I never merged this. All new development is being done for the WAMPv2 implementation on the v2 branch, and I've added an issue for that to add a similar feature (#58).